Skip to content

Conversation

@dirtycajunrice
Copy link
Contributor

@dirtycajunrice dirtycajunrice commented Jan 2, 2025


[CLI] Fix: Cannot find package "cross-spawn" on linux

TOOL-2875

fixes #5852

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR primarily focuses on updating dependencies in the package.json and pnpm-lock.yaml files, specifically adding the cross-spawn package and adjusting its version. It also refines the versioning details of existing packages.

Detailed summary

  • Added cross-spawn with version 7.0.6 to packages/thirdweb/package.json.
  • Removed previous cross-spawn entry from packages/thirdweb/package.json.
  • Updated pnpm-lock.yaml to reflect the new cross-spawn version.
  • Adjusted dependencies and their versioning details in pnpm-lock.yaml.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@dirtycajunrice dirtycajunrice requested review from a team as code owners January 2, 2025 16:40
@vercel
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:41pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:41pm
thirdweb-www ❌ Failed (Inspect) Jan 3, 2025 11:41pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:41pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 611bd14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 2, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (+0.17% 🔺) 902 ms (+0.17% 🔺) 599 ms (+55.57% 🔺) 1.6 s
thirdweb (cjs) 110.84 KB (-0.08% 🔽) 2.3 s (-0.08% 🔽) 965 ms (+17.92% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 36 ms (-51.96% 🔽) 147 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (+278.42% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (+0.08% 🔺) 383 ms (+0.08% 🔺) 154 ms (+6.62% 🔺) 537 ms

@dirtycajunrice dirtycajunrice changed the title move cross-spawn to dependencies [TOOL-2875] move cross-spawn to dependencies Jan 2, 2025
@linear
Copy link

linear bot commented Jan 2, 2025

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 3, 2025
Copy link
Contributor

Merge activity

  • Jan 3, 5:26 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find package 'cross-spawn'

4 participants